This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Add more members of filter_parser
to milli::
& From<&str>
implementation for Token
#719
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The current
milli::Filter
andmilli::FilterCondition
APIs require working with some members offilter_parser
directly thatmilli::
does not re-export to its users (at least when not parsing input usingparse
). Also, usingfilter_parser
does not make sense when using milli from an embedded context where there is no query to parse.Instead of reworking
milli::Filter
andmilli::FilterCondition
, this PR adds two non-breaking changes that ease the use of milli:filter_parser
inmilli
From<&str>
forfilter_parser::Token
Token
from a string to avoid some boilerplate.In conjunction, both of these will allow milli users to easily create a
Token
from a&str
without needing to addfilter_parser
as an extra dependency.Note: I wanted to use
FromStr
for theFrom
implementation; however, it requires returning aResult
which is not needed for the conversion. Thus, I just left it asFrom<&str>
.