This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Fix bug in handling of soft deleted documents when updating settings #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerollmops
added
the
no breaking
3 tasks
loiclec
force-pushed
the
soft-deleted-docids-settings-update-fix
branch
from
45b3d3c to
67d8cec
Compare
Kerollmops
reviewed
Dec 6, 2022
Kerollmops
approved these changes
Dec 6, 2022
irevoire
approved these changes
Dec 6, 2022
|
Let's merge this! |
Kerollmops
pushed a commit
that referenced
this pull request
Dec 6, 2022
723: Fix bug in handling of soft deleted documents when updating settings r=Kerollmops a=loiclec # Pull Request ## Related issue Fixes (partially, until merged into meilisearch) meilisearch/meilisearch#3021 ## What does this PR do? This PR fixes the bug where a `missing key in documents database` internal error message could appear when indexing documents. When updating the settings, before clearing the database and before creating the transform output, we now modify the `ExternalDocumentsIds` structure to get rid of all references to soft deleted document ids in its FSTs. It used to be that updating the settings would clear the soft-deleted document ids, but keep the original `ExternalDocumentsIds` structure. As a consequence of this, when processing a future document addition, we could wrongly believe that a document was being replaced when, in fact, it was a completely new document. See the tests `bug_3021_first`, `bug_3021_second`, and `bug_3021` for a minimal test case that would have reproduced the issue. We need to take special care to: - evaluate how users should update to v0.30.1 (containing this fix): dump? reimporting all documents from scratch? - understand IF/HOW this bug could have caused duplicate documents to be returned - and evaluate the correctness of the fix, of course :) Co-authored-by: Loïc Lecrenier <loic.lecrenier@me.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes (partially, until merged into meilisearch) meilisearch/meilisearch#3021
What does this PR do?
This PR fixes the bug where a
missing key in documents databaseinternal error message could appear when indexing documents.When updating the settings, before clearing the database and before creating the transform output, we now modify the
ExternalDocumentsIdsstructure to get rid of all references to soft deleted document ids in its FSTs.It used to be that updating the settings would clear the soft-deleted document ids, but keep the original
ExternalDocumentsIdsstructure. As a consequence of this, when processing a future document addition, we could wrongly believe that a document was being replaced when, in fact, it was a completely new document. See the testsbug_3021_first,bug_3021_second, andbug_3021for a minimal test case that would have reproduced the issue.We need to take special care to: