This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Update the contributing.md #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curquiza
suggested changes
Dec 6, 2022
Comment on lines
+64
to
+66
| ```bash | ||
| touch benchmarks/benches/datasets_paths.rs | ||
| ``` |
There was a problem hiding this comment.
No, I tried to, but git doesn't like it.
Basically, this file is auto-generated with a path in your filesystem when you run the benchmarks, and thus if we start tracking it with git, it will show up every time as a spurious change 😩
And no, force pushing the file but adding it to the .gitignore doesn't change anything, git is not meant to be used like that, if he tracks a file he'll track it whatever happens 😩
Co-authored-by: Clémentine Urquizar - curqui <clementine@meilisearch.com>
Co-authored-by: Clémentine Urquizar - curqui <clementine@meilisearch.com>
irevoire
added
no breaking
curquiza
approved these changes
Dec 7, 2022
|
bors merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.