This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Simplify primary key inference #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dureuill
added
indexing
dureuill
force-pushed
the
simpler_primary_key_inference
branch
from
8a7bf09 to
36fd2de
Compare
irevoire
previously approved these changes
Dec 20, 2022
dureuill
force-pushed
the
simpler_primary_key_inference
branch
2 times, most recently
from
1cc56fd to
bfcb75b
Compare
|
I added a log looking like this: when inference took place |
3 tasks
dureuill
changed the title
Displays log message in the form: ``` [2022-12-21T09:19:42Z INFO milli::update::index_documents::enrich] Primary key was not specified in index. Inferred to 'id' ```
dureuill
force-pushed
the
simpler_primary_key_inference
branch
from
bfcb75b to
4b166be
Compare
5 tasks
|
Build succeeded! And happy new year! 🎉
|
bors bot
added a commit
to meilisearch/meilisearch
that referenced
this pull request
Jan 4, 2023
3269: Simplify primary key inference r=dureuill a=dureuill # Pull Request ## Related issue Related to #3233 ## What does this PR do? - Integrates meilisearch/milli#752 in meilisearch - Remove `Serialize` and `Deserialize` from `error::Code` as it is unused. - No longer filter on `milli` logs when `--log-level` is "info". - `milli` only has the newly-added inference log at the `info` level (from greping `info` in the codebase) - the default value for `--log-level` is "INFO" and not "info" since `v0.30` so the filter is not active by default. - updates milli to v0.38.0 ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: Louis Dureuil <louis@meilisearch.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Related to meilisearch/meilisearch#3233
What does this PR do?
User PoV
UserError::NoPrimaryKeyCandidateFoundandUserError::MultiplePrimaryKeyCandidatesFoundImplementation-wise
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!