Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Commit

Permalink
Add review suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
gmourier committed Nov 3, 2022
1 parent ce99ce8 commit 2a2b040
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
2 changes: 1 addition & 1 deletion text/0061-error-format-and-definitions.md
Original file line number Diff line number Diff line change
Expand Up @@ -854,7 +854,7 @@ HTTP Code: `404 Not Found` when

## duplicate_index_found

`Asynchronous`
`Synchronous`

### Context

Expand Down
6 changes: 2 additions & 4 deletions text/0191-swap-indexes-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,7 @@ It's critical to deploy a new version of an index without any downtimes to the s

### 3.1. 0 downtime deployment workflow

A user has big changes to make on an index. It could be important document schema or index settings changes.

The zero-downtimes deployment looks like this:
A 0 downtime deployment looks like this:

1. Search clients search on `indexA`.
2. The developer builds a new index `indexB` representing the new index version to deploy to the search clients.
Expand All @@ -30,7 +28,7 @@ This means that for a search experience built using multiple indexes, Meilisearc

There is no need to deploy each new version of indexes one by one.

### 3.3. Enqueud Tasks After A Swap Operation Creation
### 3.3. Enqueued Tasks After A Swap Operation Creation

Tasks enqueued after an `indexSwap` task creation date do not have their `indexUid` modified when the `indexSwap` will succeed. That is, if they are enqueued on `indexA`, they will run on the new version of `indexA`.

Expand Down

0 comments on commit 2a2b040

Please sign in to comment.