Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration is not accessible through the forge mod menu #5794

Closed
term2112 opened this issue Jan 20, 2020 · 4 comments
Closed

Configuration is not accessible through the forge mod menu #5794

term2112 opened this issue Jan 20, 2020 · 4 comments

Comments

@term2112
Copy link

Please use the search functionality before reporting an issue. Also take a look at the closed issues!

Issue description:

I am not sure if this is an issue with forge itself still being in beta but all the mod configurations in the mod menu are grayed out. I do know how to change these configurations through the files themselves though although I find this to be kind of inconvenient at times. I believe that the mod creators are supposed to point forge to where the mod configuration files are to allow it to access them.

Steps to reproduce:

  1. open mods menu at startup
  2. open mechanism or any of its sub-mods
  3. the configuration option is unavailable

Version (make sure you are on the latest version before reporting):

Forge: 30.0.41
Mekanism: 9.9.3

image

@pupnewfster
Copy link
Member

The config gui has not been re-implemented in forge yet after forge was rewritten in 1.13/1.14. While it is possible to manually create all the GUI code and stuff and hook that up to the config button, I am not planning on dealing with it/trying to get the config gui working until after MinecraftForge/MinecraftForge#6421 gets merged. At which time I will test to make sure our configs show/behave properly using it and that if anything needs a localization string + key that it has one.

@pupnewfster pupnewfster added 1.15 An issue having to do with the 1.15 port Usability labels Jan 20, 2020
@term2112
Copy link
Author

I am not sure if this was recently re-implemented but I have noticed that a couple of my other mods re-implemented there settings in the mod menu. The 2 mods are xaeros minimap and worldmap.

@pupnewfster
Copy link
Member

It hasn't been (MinecraftForge/MinecraftForge#7395) and I still see no need to deal with creating our own set of GUIs when the config files work just fine, if not better in my opinion than a GUI based system.

@term2112
Copy link
Author

I did not even realize that a mod even had an option to create its own GUI. It was my mistake thinking that this was fixed when noticing that this mod had the option available.

@pupnewfster pupnewfster added this to the 10.6.6 milestone Jul 21, 2024
@pupnewfster pupnewfster modified the milestones: 10.6.6, 10.6.7 Jul 21, 2024
@pupnewfster pupnewfster modified the milestones: 10.6.7, 10.6.8 Jul 28, 2024
@pupnewfster pupnewfster modified the milestones: 10.7.3, 10.7.5 Aug 23, 2024
pupnewfster added a commit that referenced this issue Aug 23, 2024
- Adds support for editing our configs using the config GUI, and for translating their contents. #5794
- Restructure organization of entries within individual config files. This unfortunately will cause all configs to get reset as I removed a parent level node in order to make the config GUI easier to navigate.
- Fixes Mekanism's Additions description translation not being used in game
- Flip Mekanism Addition's voice key is toggle config to a push to talk config option. (Same default behavior, just is a bit better of a name)
- Slightly lowered the default `dumpExcessKeepRatio` config value (from `0.9` to `0.85`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants