Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pop-up hidden if host page styles div as position: relative #959

Closed
melink14 opened this issue Apr 6, 2022 · 1 comment · Fixed by #960
Closed

Pop-up hidden if host page styles div as position: relative #959

melink14 opened this issue Apr 6, 2022 · 1 comment · Fixed by #960
Labels
bug released UI

Comments

@melink14
Copy link
Owner

melink14 commented Apr 6, 2022

This was reported via CWS as seen on instagram.

I as thinking that the outer div didn't matter but of course the absolute positioning of the shadow popup is affected if it's inside a relative positioned parent.

I think setting resetting all styles on the shadow host to:
all: revert !important should be good to ensure we start with a blank slate for non inheritable properties.
melink14 added a commit that referenced this issue Apr 7, 2022
@melink14
fix(ui): Reset styles on the light dom container
fb23e7a 
- Add an important `all: revert` to the light dome style attribute
- Hide and show popup based on display of shadow container instead of light container. This prevents conflicts with light container reset and is more resiliant to changes to the light container.
- Adds new condition to ignore styles test and a test which ensures visibility check is accurate.

Fixes #959
@melink14 melink14 mentioned this issue Apr 7, 2022
Merged
melink14 added a commit that referenced this issue Apr 7, 2022
@melink14
fix(ui): Reset styles on the light dom container (#960)
e734a35 
- Add an important `all: revert` to the light dom style attribute
- Hide and show popup based on display of shadow container instead of light container. This prevents conflicts with light container reset and is more resiliant to changes to the light container.
- Adds new condition to ignore styles test and a test which ensures visibility check is accurate.

Fixes #959
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
melink14 pushed a commit that referenced this issue Apr 7, 2022
@semantic-release-bot
chore(release): 2.3.2
cd293ba 
### [2.3.2](v2.3.1...v2.3.2) (2022-04-07)

### Bug Fixes

* **ui:** Make Google Doc Canvas checks more lenient ([#962](#962)) ([6809154](6809154)), closes [#897](#897) [#881](#881)
* **ui:** Reset styles on the light dom container ([#960](#960)) ([e734a35](e734a35)), closes [#959](#959)
@melink14
Copy link
Owner Author

melink14 commented Apr 7, 2022

🎉 This issue has been resolved in version 2.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug released UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui): Reset styles on the light dom container melink14/rikaikun
1 participant
@melink14