Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Migrate to MV3 #2168

Merged
merged 1 commit into from
Aug 25, 2024
Merged

feat!: Migrate to MV3 #2168

merged 1 commit into from
Aug 25, 2024

Conversation

melink14
Copy link
Owner

@melink14 melink14 commented Aug 25, 2024

  • Update manifest
  • Switch to newer APIs
  • Patch chrome stub with new APIs for testing
  • Move clipboard and audio functionality into offscreen page (requires Chrome 109)
  • rikaikun now remembers enabled/on state between startups; required due to ephemeral nature of new scripts.

BREAKING CHANGE: MV3 with offscreen pages requires at least Chrome 109 which is the new minimum version.
Fixes #187
Fixes #65

Copy link

codecov bot commented Aug 25, 2024

Codecov Report

Attention: Patch coverage is 75.12690% with 49 lines in your changes missing coverage. Please review.

Project coverage is 88.15%. Comparing base (c24c697) to head (e6b0933).
Report is 4 commits behind head on main.

Files Patch % Lines
extension/background.ts 54.83% 28 Missing ⚠️
extension/offscreen-setup.ts 56.00% 11 Missing ⚠️
extension/rikaichan.ts 87.23% 6 Missing ⚠️
extension/data.ts 77.77% 2 Missing ⚠️
extension/rikaicontent.ts 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2168      +/-   ##
==========================================
- Coverage   89.11%   88.15%   -0.97%     
==========================================
  Files          15       15              
  Lines        4954     5008      +54     
  Branches      512      516       +4     
==========================================
  Hits         4415     4415              
- Misses        530      587      +57     
+ Partials        9        6       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@melink14 melink14 force-pushed the melink14/mv3 branch 2 times, most recently from 1432094 to ca3c3ca Compare August 25, 2024 13:24
@melink14 melink14 changed the title feat: Migrate to MV3 feat!: Migrate to MV3 Aug 25, 2024
@melink14 melink14 added the self-approved Label which allows mergify to approve owner's PRs label Aug 25, 2024
Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

melink14 says it's fine so it must be fine!

- Update manifest
- Switch to newer APIs
- Patch chrome stub with new APIs for testing
- Move clipboard and audio functionality into offscreen page (requires Chrome 109)
- rikaikun now remembers on state between startups; required due to ephemeral nature of new scripts.

BREAKING CHANGE: MV3 with offscreen pages requires at least Chrome 109 which is the new minimum version.
Fixes #187
Fixes #65
@melink14 melink14 merged commit 8a47af3 into main Aug 25, 2024
7 of 11 checks passed
@melink14 melink14 deleted the melink14/mv3 branch August 25, 2024 13:41
melink14 pushed a commit that referenced this pull request Aug 25, 2024
## [3.0.0](v2.5.61...v3.0.0) (2024-08-25)

### ⚠ BREAKING CHANGES

* MV3 with offscreen pages requires at least Chrome 109 which is the new minimum version.

### Features

* Migrate to MV3 ([#2168](#2168)) ([8a47af3](8a47af3)), closes [#187](#187) [#65](#65)

### Bug Fixes

* **manifest:** Remove comment from manifest.json ([#2169](#2169)) ([d76fc31](d76fc31))
melink14 pushed a commit that referenced this pull request Aug 25, 2024
## [3.0.0](v2.5.61...v3.0.0) (2024-08-25)

### ⚠ BREAKING CHANGES

* MV3 with offscreen pages requires at least Chrome 109 which is the new minimum version.

### Features

* Migrate to MV3 ([#2168](#2168)) ([8a47af3](8a47af3)), closes [#187](#187) [#65](#65)

### Bug Fixes

* **manifest:** Remove comment from manifest.json ([#2169](#2169)) ([d76fc31](d76fc31))
@melink14
Copy link
Owner Author

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released self-approved Label which allows mergify to approve owner's PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to Manifest V3 Enable on startup
1 participant