Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Support Google Docs annotated canvas mode #865

Merged
merged 1 commit into from
Feb 22, 2022
Merged

fix: Support Google Docs annotated canvas mode #865

merged 1 commit into from
Feb 22, 2022

Conversation

melink14
Copy link
Owner

  • Adds support for extracting annotated text
  • Unconditionally, enables annotated canvas mode in Google Docs
  • Adds new background.ts tests, since all previous tests were html fallback related.

Fixes #852

@codecov
Copy link

codecov bot commented Feb 21, 2022 •
edited
Loading

Codecov Report

Merging #865 (bf6b32f) into main (a155212) will increase coverage by 7.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #865      +/-   ##
==========================================
+ Coverage   41.57%   48.63%   +7.05%     
==========================================
  Files           7        7              
  Lines        2908     2996      +88     
  Branches       53       62       +9     
==========================================
+ Hits         1209     1457     +248     
+ Misses       1699     1539     -160
Impacted Files Coverage Δ
extension/background.ts 49.38% <ø> (-0.62%) ⬇️
extension/docs-annotate-canvas.ts 100.00% <100.00%> (ø)
extension/rikaicontent.ts 61.69% <100.00%> (+14.67%) ⬆️
extension/rikaichan.ts 51.96% <0.00%> (+1.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a155212...bf6b32f. Read the comment docs.

@melink14 melink14 force-pushed the melink14/issue852/Support-Google-Docs-Annotated-Canvas-Mode branch 6 times, most recently from 769ba98 to afc876f Compare February 22, 2022 09:40
@melink14 melink14 marked this pull request as ready for review February 22, 2022 09:41
@melink14 melink14 force-pushed the melink14/issue852/Support-Google-Docs-Annotated-Canvas-Mode branch from afc876f to 9d48078 Compare February 22, 2022 13:35
@melink14
fix: Support Google Docs annotated canvas mode
bf6b32f 
- Adds support for extracting annotated text
- Unconditionally, enables annotated canvas mode in Google Docs
- Adds new background.ts tests, since all previous tests were html fallback related.

Fixes #852
@melink14 melink14 force-pushed the melink14/issue852/Support-Google-Docs-Annotated-Canvas-Mode branch from 9d48078 to bf6b32f Compare February 22, 2022 14:20
@melink14 melink14 merged commit bb9b254 into main Feb 22, 2022
@melink14 melink14 deleted the melink14/issue852/Support-Google-Docs-Annotated-Canvas-Mode branch February 22, 2022 14:25
melink14 pushed a commit that referenced this pull request Feb 22, 2022
@semantic-release-bot
chore(release): 2.1.31
4daaef8 
### [2.1.31](v2.1.30...v2.1.31) (2022-02-22)

### Bug Fixes

* **dict:** Update dictionaries to latest versions ([#864](#864)) ([77873c5](77873c5))
* Support Google Docs annotated canvas mode ([#865](#865)) ([bb9b254](bb9b254)), closes [#852](#852)
@melink14
Copy link
Owner Author

🎉 This PR is included in version 2.1.31 🎉

The release is available on:

Your semantic-release bot 📦🚀

@melink14
Copy link
Owner Author

Forgot to update manifest with new content script name so this PR causes breakage.

melink14 added a commit that referenced this pull request Feb 22, 2022
@melink14
feat: Enables Google docs annotate canvas in manifest
de2cbcf 
Previous implementation (bb9b254) of this functionality breaks due to no manifest change.

This one is marked feat since the previous attempt was marked 'fix' accidentally.

Fixes #865
@melink14 melink14 mentioned this pull request Feb 22, 2022
Merged
melink14 added a commit that referenced this pull request Feb 22, 2022
@melink14
feat: Enables Google docs annotate canvas in manifest (#868)
c50d60e 
Previous implementation (bb9b254) of this functionality breaks due to no manifest change.

This one is marked feat since the previous attempt was marked 'fix' accidentally.

Fixes #865
melink14 pushed a commit that referenced this pull request Feb 23, 2022
@semantic-release-bot
chore(release): 2.2.0
1c3af56 
## [2.2.0](v2.1.31...v2.2.0) (2022-02-23)

### Features

* Enables Google docs annotate canvas in manifest ([#868](#868)) ([c50d60e](c50d60e)), closes [#865](#865)
@melink14
Copy link
Owner Author

🎉 This issue has been resolved in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Google Docs Annotated Canvas Mode
1 participant
@melink14