Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): Isolate rikaikun popup from host page via shadow DOM and all: revert #933

Merged
merged 6 commits into from
Apr 2, 2022
Merged

feat(ui): Isolate rikaikun popup from host page via shadow DOM and all: revert #933

merged 6 commits into from
Apr 2, 2022

Commits on Apr 2, 2022

  1. test(ui): Use 立 instead of 人 for kanji entry test 

    人 does not have any verb forms meaning the display of the extra furigana isn't tested.
    @melink14
    melink14 committed Apr 2, 2022
    Configuration menu
    Copy the full SHA
    3315acf View commit details
    Browse the repository at this point in the history

  2. feat(ui): Isolate rikaikun popup from host page via shadow Dom and `a… 

    …ll: revert`

- Creates a div inside of shadow root to contain all styles and modifications.
- Updates CSS to use `all: revert` instead of previous adhoc reset.
- Installs CSS directly into the shadow DOM as per best practices.
- Fallsback to `all: initial` for older Chrome browsers.
- Removes special check for text files since chrome renders them as normal HTML pages.

Fixes #221
    @melink14
    melink14 committed Apr 2, 2022
    Configuration menu
    Copy the full SHA
    2eaf0fc View commit details
    Browse the repository at this point in the history

  3. test(visual): Update baselines with new screenshots

    @github-actions
    github-actions[bot] committed Apr 2, 2022
    Configuration menu
    Copy the full SHA
    8ede939 View commit details
    Browse the repository at this point in the history

  4. test(visual): Update baselines with new screenshots

    @github-actions
    github-actions[bot] committed Apr 2, 2022
    Configuration menu
    Copy the full SHA
    b73a377 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'melink14/betterkanjitest' into melink14/shadow-dom

    @melink14
    melink14 committed Apr 2, 2022
    Configuration menu
    Copy the full SHA
    66f6c1d View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into melink14/shadow-dom

    @melink14
    melink14 committed Apr 2, 2022
    Configuration menu
    Copy the full SHA
    3a67c5c View commit details
    Browse the repository at this point in the history