-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: viewproptypes export from deprecated prop types #929
base: master
Are you sure you want to change the base?
fix: viewproptypes export from deprecated prop types #929
Conversation
Any idea when this might be merged? |
Unfortunately no |
Isn't there a way to do without viewproptype? Because as I see it, it's only a workaround to use deprecated-react-native-proptypes. Thanks for this PR anyway, I was struggling on this issue today and found this solution too. |
A patch might also be created from my change list if you like. It would be really nice if a maintainer could have looked at it @bd-arc |
To solve the issue temporarily, I have forked this branch and merged it into the fork's master. You can install like: NPM
YARN
Until when the PR is merged. |
@Anthony-Buisson @bd-arc can you please merge this 🙏🏼 |
This helped me to solve the issue. |
The react-native-new-snap-carousel available on npm |
praying to the champions of |
Platforms affected
iOS & Android Referencing RN Issue #33734
What does this PR do?
Fixes issue #928
What testing has been done on this change?
All occurrences of ViewPropType import is changed to react-native's new deprecated-react-native-prop-types repo
Nothing to test
Tested features checklist
enableMomentum
)vertical
)activeSlideAlignment
)autoplay
)loop
)ScrollView
/FlatList
carousels (propuseScrollView
)ParallaxImage
componentPagination
component