ENH Add reference label for rst #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melissawm
reviewed
Dec 10, 2023
melissawm
approved these changes
Dec 11, 2023
|
It would be nice to have a consistent ref label for both rST and MyST, since some projects (including some of mine) use a mix of both formats. I can add that plus tests in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #85
Adds reference label for .rst. AFAICT for md, you can just use the header to cross reference, so no special label needed.
I do not know how best to test this. Could I add a cross link to
test/sources/test-rst/index.rstand then amend the test only fortestroot="rst"?