Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chosen 1.x compatibiliy #65

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

michaelperrin
Copy link

This PR makes the necessary changes to Ajax Chosen to make it compatible with Chosen 1.0.0 (but not compatible anymore with 0.x versions).

A quote from the Chosen 1.0.0 release notes:

  • All CSS class names have been renamed from a chzn- root to a chosen- root.
  • All custom Chosen events starting with liszt are now prefaced with a chosen:

All files have been updated: the CoffeeScript one, the JS one, and the minified JS version.

@michaelperrin
Copy link
Author

Hi @meltingice , I think this PR should really be merged...

I would advice to tag first the current master version of Chosen (before merging this PR) as a 0.3.0 release, and then to merge this PR.

People using Chosen 0.x would use the 0.3.x branch of Ajax Chosen and for those using Chosen 1.x, the master branch (or a new 1.x branch) should be used, based on this PR.

There are a lot of commits in this PR, but it's just because I changed my commiter name for previous commits. The changelog is therefore pretty simple.

@danteoh
Copy link

danteoh commented Nov 4, 2013

bump

@ghost
Copy link

ghost commented Dec 5, 2013

This would be a really nice merge, would like to use 1.0 with ajax-chosen.

@michaelperrin
Copy link
Author

@cameronwilby As my PR was not merged (and an other one as well), I merged my PR on the master branch of my fork that you can find here : https://github.com/michaelperrin/ajax-chosen/

You can find the compiled libraries (both minified and not minified) in the lib folder, and the CoffeeScript one in the src folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants