Implemented ShadowingInterceptor #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move `ShadowingInterceptor` to a new package `shadowing` - Refactor request handling to log status codes from shadow targets - Update example configurations to demonstrate shadow requests - Enhance README with instructions and configurations for running the example
- Simplify request sending logic by removing conditional check for "shadow-request-send". - Add a short description for the interceptor to clarify its purpose. - Enhance Javadoc for `setTargets` method to clearly explain the function and expected targets.
- Implement initial unit tests for `ShadowingInterceptor` in `ShadowingInterceptorTest`. - Mock `Target` class to verify behavior of `getDestFromTarget` method with and without URL. - Change visibility of `getDestFromTarget` and `performCall` methods to public for test accessibility. - Refactor asynchronous request handling in `cloneRequestAndSend` method to improve error logging.
|
This pull request needs "/ok-to-test" from an authorized committer. |
|
/ok-to-test |
predic8
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.