Internal proxy example fix #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change configuration file reference in `service-proxy.sh` from `proxies_soap.xml` to `proxies.xml`. - Update copyright year in `InternalProxyTest.java` from 2022 to 2024. - Refactor test methods to enhance readability and consistency. - Modify the test for express order processing to use RestAssured for HTTP requests. - Add tests for regular order scenarios to ensure they fall through correctly.
|
This pull request needs "/ok-to-test" from an authorized committer. |
|
/ok-to-test |
predic8
requested changes
Dec 17, 2024
distribution/src/test/java/com/predic8/membrane/examples/tests/InternalProxyTest.java
Outdated
Show resolved
Hide resolved
Clarify instructions for running the internal proxy example in the README file. Adjust the base URL in `InternalProxyTest` to match the correct port. Modify the assertions to reflect expected responses, ensuring they align with the newly defined processing routes for express and normal orders.
|
/ok-to-test |
predic8
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.