Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace cstr! with c"" literals when 1.77 is released #623

Closed
kkysen opened this issue Dec 11, 2023 · 0 comments · Fixed by #943
Closed

Replace cstr! with c"" literals when 1.77 is released #623

kkysen opened this issue Dec 11, 2023 · 0 comments · Fixed by #943
Assignees
@kkysen
Labels
low priority Issues that we would like to address at some point in the future

Comments

@kkysen
Copy link
Collaborator

kkysen commented Dec 11, 2023 •
edited
Loading

rust-lang/rust#117472 stabilized c"" string literals and is supposed to be released with 1.77, so when that comes out, we can update our toolchain, use c"" string literals instead of the cstr! macro and the cstr crate.

See #619 (comment).
@kkysen kkysen self-assigned this Dec 11, 2023
@rinon rinon added the low priority Issues that we would like to address at some point in the future label Dec 13, 2023
@kkysen kkysen changed the title Replace cstr! with c"" literals when 1.76 is released Replace cstr! with c"" literals when 1.77 is released Feb 27, 2024
@kkysen kkysen mentioned this issue Apr 1, 2024
Merged
kkysen added a commit that referenced this issue Apr 1, 2024
@kkysen
rust-toolchain.toml: Upgrade to nightly-2024-04-01 (#943)
46f48e9 
`rust-analyzer` has been showing me a ton of warnings lately, things
like `non_camel_case_types`, which we allow for `rustc`, and which I
realized is due to the `rust-analyzer` version being new, and our
`rustc` toolchain being old. Upgrading it to the latest nightly fixes
this. These warnings are especially annoying as they slow down my edit
and compile cycle, and we are due for an upgrade anyways, though
hopefully we can go to `stable` next (once #620 is merged, though it
hasn't been enough of a priority).

We can also replace the `target_arch = "arm"`-dependent
`#![feature(stdsimd)]` with the much more specific and more likely to
stabilize soon `#![feature(stdarch_arm_feature_detection)]`.

* Fixes #623.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkysen kkysen

Labels
low priority Issues that we would like to address at some point in the future
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rust-toolchain.toml: Upgrade to nightly-2024-04-01 memorysafety/rav1d
2 participants
@rinon @kkysen