-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cargo setup method and enable arm64 builds again #108
Conversation
That is a very old issue. Sparse registry has been available on stable rust for a long time. |
They switched the default to sparse. https://doc.rust-lang.org/cargo/reference/config.html#registriescrates-ioprotocol https://releases.rs/docs/1.70.0/ (Near the bottom under Cargo, says "Make sparse the default protocol for crates.io") 1.70.0 is the version of cargo that made sparse the default. |
debian bookworm is still on an ancient version. So just switching to the rustup install like you have (no need for nightly) should be enough. No parameters needed. |
Dockerfile
Outdated
@@ -1,9 +1,9 @@ | |||
FROM debian:bookworm-slim AS base | |||
FROM debian:latest AS base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for removing slim? (latest is currently bookworm)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@junderw I misread your original message saying it was due to the ancient version Debian was using, so I ended up changing the Debian version without checking if bookworm wasn't already the latest. I'll change it back to slim.
We disabled arm64 builds because the process was getting stuck on the
updating crates.io index
step.This PR applies the workaround suggested here so now we have working builds again but they are taking 1h40min on Github agents.