Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cargo setup method and enable arm64 builds again #108

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Conversation

knorrium
Copy link
Member

We disabled arm64 builds because the process was getting stuck on the updating crates.io index step.

This PR applies the workaround suggested here so now we have working builds again but they are taking 1h40min on Github agents.

@knorrium knorrium requested review from wiz and junderw November 11, 2024 16:45
@junderw
Copy link
Member

junderw commented Nov 11, 2024

That is a very old issue. Sparse registry has been available on stable rust for a long time.

@junderw
Copy link
Member

junderw commented Nov 11, 2024

They switched the default to sparse.

https://doc.rust-lang.org/cargo/reference/config.html#registriescrates-ioprotocol

https://releases.rs/docs/1.70.0/ (Near the bottom under Cargo, says "Make sparse the default protocol for crates.io")

1.70.0 is the version of cargo that made sparse the default.

@junderw
Copy link
Member

junderw commented Nov 11, 2024

debian bookworm is still on an ancient version.

So just switching to the rustup install like you have (no need for nightly) should be enough. No parameters needed.

@knorrium knorrium changed the title Use nightly cargo and enable arm64 builds again Update cargo setup method and enable arm64 builds again Nov 12, 2024
Dockerfile Outdated
@@ -1,9 +1,9 @@
FROM debian:bookworm-slim AS base
FROM debian:latest AS base
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for removing slim? (latest is currently bookworm)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@junderw I misread your original message saying it was due to the ancient version Debian was using, so I ended up changing the Debian version without checking if bookworm wasn't already the latest. I'll change it back to slim.

@knorrium knorrium closed this Nov 12, 2024
@knorrium knorrium reopened this Nov 12, 2024
@wiz wiz merged commit e5c1587 into mempool Nov 14, 2024
7 checks passed
@wiz wiz deleted the knorrium/arm64 branch November 14, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants