Dev to Main: Refactor script for dynamic settings, registry and oscdimg.exe fix #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added dynamic loading of oscdimg settings and XAML URL from wimutil-settings.json. - Integrated branch-based configuration with fallback to default branch. - Implemented UTC-based signing date validation for oscdimg.exe. - Centralized oscdimg.exe expected hash and signing date in JSON config. - Fixed GUI loading issue by setting "DisableFirstRunCustomize" registry entry at script start.
- Implemented branch detection from URL to dynamically set the current branch. - Enhanced configuration fetching with branch-specific logic and fallback to default branch. - Ensured dynamic URLs for XAML and oscdimg are correctly loaded from JSON config. - Validated required keys in the configuration file to prevent runtime errors. - Improved error handling for missing or invalid branches and configuration entries. - Removed reliance on local file paths, ensuring full compatibility with remote execution via irm.
- Shortened and centralized branch-specific configuration logic for better maintainability. - Improved fallback mechanism to handle missing branch settings in the JSON file. - Validated critical configuration keys to ensure runtime stability. - Enhanced error handling for configuration loading and branch detection.
- Added debugging for branch detection to log InvocationName and PSCommandPath. - Improved branch detection logic to reliably extract branch name from invocation URL. - Enhanced fallback mechanism to default to 'main' branch when detection fails. - Constructed configuration URL dynamically based on the detected branch. - Improved error handling for invalid or missing branch settings.
- Enhanced branch detection logic to handle remote execution via irm. - Added fallback to detect branch from pipeline input if InvocationName fails. - Improved error handling and debugging for branch detection and configuration loading.
…or improved reliability
…to update the currentbranch detection
…d manually switch between branches
update branch detection
remove " " white space in launch command.
This was referenced Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor script for dynamic settings and registry fix
wimutil-settings.jsonto store config for the project.mainanddevbranches and comment out the one not being used. (needs more work)