Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WC-2533][WC-2581] RTE v4: quill v2 #1119

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

[WC-2533][WC-2581] RTE v4: quill v2 #1119

wants to merge 23 commits into from

Conversation

gjulivan
Copy link
Contributor

@gjulivan gjulivan commented Jun 18, 2024

Pull request type

Breaking change
this will be version 4.0 of Rich Text Editor.
new rich text editor using Quill V2.


Description

Due to the license changes on TinyMCE 7.0,
we can't upgrade to tinymce 7.0

Thus, we decide to continue using Quill (as in Rich Text v 1)
which has been back with their Version 2.0.

What should be covered while testing?

everything.

CSP,
a11y,
functionality.

@gjulivan gjulivan force-pushed the RTE-v-4 branch 6 times, most recently from 3ff4b14 to c9dbc89 Compare June 25, 2024 14:00
@gjulivan gjulivan marked this pull request as ready for review June 25, 2024 14:00
@gjulivan gjulivan requested a review from a team as a code owner June 25, 2024 14:00
@gjulivan gjulivan changed the title RTE v4: quill v2 [WC-2533] RTE v4: quill v2 Jun 25, 2024
@gjulivan gjulivan force-pushed the RTE-v-4 branch 3 times, most recently from 78fbe14 to 4a77812 Compare July 2, 2024 08:19
@gjulivan gjulivan force-pushed the RTE-v-4 branch 6 times, most recently from 880528d to b91897a Compare August 7, 2024 15:42
@gjulivan gjulivan changed the title [WC-2533] RTE v4: quill v2 [WC-2533][WC-2581] RTE v4: quill v2 Aug 7, 2024
@gjulivan gjulivan force-pushed the RTE-v-4 branch 8 times, most recently from e0fbac5 to 519ba3a Compare August 29, 2024 12:31
@gjulivan gjulivan force-pushed the RTE-v-4 branch 3 times, most recently from 1caf5d6 to 97a2e63 Compare September 18, 2024 09:32
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixing flaky test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants