-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WC-2533][WC-2581] RTE v4: quill v2 #1119
Open
gjulivan
wants to merge
23
commits into
main
Choose a base branch
from
RTE-v-4
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+2,948
−1,130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjulivan
force-pushed
the
RTE-v-4
branch
6 times, most recently
from
June 25, 2024 14:00
3ff4b14
to
c9dbc89
Compare
gjulivan
force-pushed
the
RTE-v-4
branch
3 times, most recently
from
July 2, 2024 08:19
78fbe14
to
4a77812
Compare
gjulivan
force-pushed
the
RTE-v-4
branch
6 times, most recently
from
August 7, 2024 15:42
880528d
to
b91897a
Compare
gjulivan
changed the title
[WC-2533] RTE v4: quill v2
[WC-2533][WC-2581] RTE v4: quill v2
Aug 7, 2024
gjulivan
force-pushed
the
RTE-v-4
branch
8 times, most recently
from
August 29, 2024 12:31
e0fbac5
to
519ba3a
Compare
gjulivan
force-pushed
the
RTE-v-4
branch
3 times, most recently
from
September 18, 2024 09:32
1caf5d6
to
97a2e63
Compare
gjulivan
commented
Sep 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixing flaky test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Breaking change
this will be version 4.0 of Rich Text Editor.
new rich text editor using Quill V2.
Description
Due to the license changes on TinyMCE 7.0,
we can't upgrade to tinymce 7.0
Thus, we decide to continue using Quill (as in Rich Text v 1)
which has been back with their Version 2.0.
What should be covered while testing?
everything.
CSP,
a11y,
functionality.