Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Datagrid): made pagination visible in virtual scrolling & load more #1125

Closed
wants to merge 9 commits into from

Conversation

sharadsums
Copy link
Contributor

@sharadsums sharadsums commented Jun 21, 2024

Pull request type
Added feature to have pagination also visible on virtual scrolling & loadmore.

Description
This is to facilitate users when they want to see paging count in all pagination option
it will be in format << 1 to page item count of total count>> for virtual scrolling and load more

What should be covered while testing?
Pagination conditions should work in all conditions.

@iobuhov
Copy link
Collaborator

iobuhov commented Oct 16, 2024

Hi @sharadsums, we use git rebase to manage updates. We using rebase to have linear commit history. So, can you please create new branch and add you changes on top of main?

@sharadsums
Copy link
Contributor Author

Hi @iobuhov
Yes sure will do

@sharadsums sharadsums closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants