Remove 100% cap for battery_lvl in fineoffset_ws90.c #2765
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No other drivers cap the battery level, so this one should not either. The WS90 backup power, used when the solar photovoltatic charged supercap is empty, is provided by 2 AA batteries. The standard manufacturer specification is that the nominal voltage of a fresh alkaline battery is 1.5V. The voltage of a new alkaline battery ranges from 1.50V to 1.65V, depending on the purity of chemistry and the quality of manufacturing. The voltage of a new lithium iron disulphide battery is 1.72V. The lithium iron disulphide chemistry is good down to -50C and has an operational life of 15 years, so it is often used for weather stations such as the WS90. It is useful to the user to be able to see a Battery Level >100% to let them know that they have a pair of very high quality batteries installed and that they are fully fresh.
|
I second that we should not change correc values that are just slightly out of bounds. |
|
Isn't this a dup of #2728? Why did resubmit the same patch? |
|
In this pull request #2448 we talked about this issue, and you thought we should clip the results at 100% (1.00). |
|
it is a dupe of #2728 which i closed, and then redid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No other drivers cap the battery level, so this one should not either.
The WS90 backup power, used when the solar photovoltatic charged supercap is empty, is provided by 2 AA batteries.
The standard manufacturer specification is that the nominal voltage of a fresh alkaline battery is 1.5V.
The voltage of a new alkaline battery ranges from 1.50V to 1.65V, depending on the purity of chemistry and the quality of manufacturing.
The voltage of a new lithium iron disulphide battery is 1.72V. The lithium iron disulphide chemistry is good down to -50C and has an operational life of 15 years, so it is often used for weather stations such as the WS90.
It is useful to the user to be able to see a Battery Level >100% to let them know that they have a pair of very high quality batteries installed and that they are fully fresh.