Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Terraform 0.15 or later #105

Merged
merged 3 commits into from
Jan 21, 2022
Merged

Support Terraform 0.15 or later #105

merged 3 commits into from
Jan 21, 2022

Conversation

KeisukeYamashita
Copy link
Contributor

WHAT

I have supported Terraform version >= 0.15

WHY

For #104.
Because tfnotify can't parse failure messages from 0.15, we can't use it. Thus, this PR aims to support it.

@KeisukeYamashita
Add testcase for 0.15 plan and apply error
f3cbdc2 
Signed-off-by: KeisukeYamashita <19yamashita15@gmail.com>
@KeisukeYamashita
Update commet for testname
b364d7a 
Signed-off-by: KeisukeYamashita <19yamashita15@gmail.com>
@KeisukeYamashita
Update regex for fail parser
823ebf5 
Signed-off-by: KeisukeYamashita <19yamashita15@gmail.com>
@KeisukeYamashita KeisukeYamashita linked an issue Jan 20, 2022 that may be closed by this pull request
Support Terraform 0.15 or later #104
Closed
@KeisukeYamashita KeisukeYamashita changed the title Support terraform 0 15 or later Support Terraform 0.15 or later Jan 20, 2022
drlau
drlau approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@drlau drlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Actually terraform 0.15 introduced refresh only plans and apply's, which have different syntax. This will at least fix 0.15 and up in the case of an error though.

@drlau drlau merged commit d912440 into mercari:master Jan 21, 2022
@KeisukeYamashita KeisukeYamashita deleted the support-terraform-0-15-or-later branch January 21, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drlau drlau drlau approved these changes

@babarot babarot Awaiting requested review from babarot

@dtan4 dtan4 Awaiting requested review from dtan4 dtan4 is a code owner

@micnncim micnncim Awaiting requested review from micnncim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Terraform 0.15 or later
2 participants
@KeisukeYamashita @drlau