Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand on no changes label to support other plan results #74

Merged
merged 7 commits into from
Jun 2, 2020

Conversation

drlau
Copy link
Member

@drlau drlau commented May 28, 2020

WHAT

This PR expands on #72 and adds labels for other terraform plan results.

WHY

This helps identify plan results at a glance and allows for CI actions depending on the result.

@drlau drlau requested a review from babarot May 28, 2020 02:27
@drlau drlau requested a review from dtan4 as a code owner May 28, 2020 02:27
@drlau drlau changed the title Dylan/result label set Expand on no changes label to support other plan results May 28, 2020
@babarot
Copy link
Contributor

babarot commented Jun 1, 2020

Sorry for the late reply..! I'll review this

Copy link
Contributor

@babarot babarot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@babarot
Copy link
Contributor

babarot commented Jun 2, 2020

Thank you for contribution! I'm gonna merge this and create the release.

@babarot babarot merged commit c8c8bae into master Jun 2, 2020
@babarot babarot deleted the dylan/result-label-set branch June 2, 2020 14:49
@babarot
Copy link
Contributor

babarot commented Jun 2, 2020

👉 https://github.com/mercari/tfnotify/releases/tag/v0.6.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants