Add per environment labels for resources #121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscr
changed the title
tobiasgiese
reviewed
May 10, 2023
|
|
||
| // We could also use the naming to detect env. | ||
| environmentFromName := "" | ||
| if strings.Contains(srv.Name, "test-2") { |
There was a problem hiding this comment.
I don't get this test-2 string. What do you want to do with this?
There was a problem hiding this comment.
Sorry so this was a long time ago and (one of) my first pr so it's pretty unclear what the idea is or if it's useful. If I recall correctly the things was we may have multiple clusters for different purposes and the environment is in the name. E g foo-test-1 or foo-test-2. The idea was to provide kosmoo with a list of environments to look for [test-1, test-2] and then check if the name contains one of environments and if so use it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issues #103 and #106.
There are some suggestions how per environment labels could be added using different strategies.
Would any of these be acceptable for you?
Environment detection with name
Output from kosmoo
The environments would need to be passed to kosmoo in some form to ensure it knows what to look for. If nothing is passed then it doesn't need to look. This should be pretty straight forward update.
Environment with OpenStack metadata label added:
I added a metadata label to the server "env": "kosmooTest"
Output from kosmoo
Need to verify this is possible with cinder. But otherwise works pretty much as expected.
Environment with Kube labels
Similar to above. Should be possible and simpler for certain resources.