Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement fwaasv2 support #25

Merged
merged 4 commits into from
Oct 21, 2020
Merged

implement fwaasv2 support #25

merged 4 commits into from
Oct 21, 2020

Conversation

chrischdi
Copy link
Contributor

  • use gophercloud fork for fwaasv2 support
  • Refactors pkg/metrics/fwaasv1.go to name v1
  • Implements pkg/metrics/fwaasv2.go to scrape fwaasv2 firewall groups

@chrischdi chrischdi added the hacktoberfest-accepted Accept for hacktoberfest label Oct 20, 2020
tobiasgiese
tobiasgiese suggested changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@tobiasgiese tobiasgiese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one tiny nit

pkg/metrics/fwaasv2.go Outdated Show resolved Hide resolved
@chrischdi chrischdi merged commit a17b4a0 into master Oct 21, 2020
@chrischdi chrischdi deleted the schloc/fwaasv2-support branch October 21, 2020 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasgiese tobiasgiese tobiasgiese requested changes

@sbueringer sbueringer sbueringer approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Accept for hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrischdi @sbueringer @tobiasgiese