Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oid parameter missing in DtcDop.decode_from_pdu #355

Closed
svnmic opened this issue Oct 22, 2024 · 1 comment
Closed

oid parameter missing in DtcDop.decode_from_pdu #355

svnmic opened this issue Oct 22, 2024 · 1 comment

Comments

@svnmic
Copy link

svnmic commented Oct 22, 2024 

        return DiagnosticTroubleCode(
            trouble_code=trouble_code,
            odx_id=cast(OdxLinkId, None),
            short_name=f'DTC_{trouble_code:06x}',
            long_name=None,
            description=None,
            text=None,
            display_trouble_code=None,
            level=None,
            is_temporary_raw=None,
            sdgs=[],
        )
andlaus added a commit to andlaus/odxtools that referenced this issue Oct 28, 2024
@andlaus
attempt to fix issue mercedes-benz#354 and mercedes-benz#355
3277e90 
due to some copy-and-pasto, `DynDefinedSpec._build_odxlinks()`
unconditionally called itself and the `oid` parameter was missing from
the fallback code for DTC decoding. (Be aware that the latter points
towards an incomplete dataset.)

Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io>
Signed-off-by: David Helwig <david.helwig@mbition.io>
andlaus added a commit that referenced this issue Oct 30, 2024
@andlaus
Merge pull request #356 from andlaus/fix_dyndef_spec
5969a3a 
attempt to fix issue #354 and #355
@andlaus
Copy link
Collaborator

andlaus commented Oct 30, 2024

#356 should fix that. Let's close the issue for now...

@andlaus andlaus closed this as completed Oct 30, 2024
nada-ben-ali pushed a commit to nada-ben-ali/odxtools that referenced this issue Dec 9, 2024
@andlaus @nada-ben-ali
attempt to fix issue mercedes-benz#354 and mercedes-benz#355
c0ce0ff 
due to some copy-and-pasto, `DynDefinedSpec._build_odxlinks()`
unconditionally called itself and the `oid` parameter was missing from
the fallback code for DTC decoding. (Be aware that the latter points
towards an incomplete dataset.)

Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io>
Signed-off-by: David Helwig <david.helwig@mbition.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andlaus @svnmic