Add support for InternalConstr #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willzhang05
force-pushed
the
internalconstr-support
branch
from
52892db to
9024f5f
Compare
andlaus
reviewed
Dec 5, 2023
There was a problem hiding this comment.
looks pretty good. After some minor cleanups it's ready to be merged.
Ideally, I'd prefer to have adherence to the internal and physical constraints to be checked in the en- and decoding logic, but if this is too much work, it can be deferred and PR can go in as-is (plus the cleanups mentioned above)
|
@willzhang05: what's the status here? |
|
@andlaus Sorry, been busy with some other things, will try to address these later this week. |
Great to read :) (I was just wondering if this was still on your radar...) |
willzhang05
force-pushed
the
internalconstr-support
branch
4 times, most recently
from
89eca3d to
cad2218
Compare
kayoub5
reviewed
Dec 14, 2023
kayoub5
reviewed
Dec 14, 2023
kayoub5
reviewed
Dec 14, 2023
willzhang05
force-pushed
the
internalconstr-support
branch
from
cad2218 to
2b8f33d
Compare
kayoub5
approved these changes
Dec 14, 2023
|
looks good; let's merge. thanks everybody! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the classes based on the schema in ISO 22901-1:2008 pg. 376-377, 394