Implement remaining compumethods #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather "implement": Being a python library, `odxtools` cannot en- or decode any parameters which use this compumethod because the ODX standard mandates the referenced program code to be Java source code using a specific Java interface. That said, files which use such compu methods get properly parsed now (hopefully). Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Christian Hackenbeck <christian.hackenbeck@mbition.io>
This compu method uses transfer functions based on a rational functions. Note that, since rational functions are not invertible in general, the physical-to-internal mapping is only available if it is explicitly specified via COMPU-PHYS-TO-INTERNAL and thus parameters which use such compu methods can only be encoded if both directions are specified. (TODO: Add possibility to directly specify internal values for the purpose of encoding messages.) Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Christian Hackenbeck <christian.hackenbeck@mbition.io>
Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Christian Hackenbeck <christian.hackenbeck@mbition.io>
we now ignore some files autogenerated by git and emacs as well as most of the stuff contained within PDX archives. Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Christian Hackenbeck <christian.hackenbeck@mbition.io>
|
@nada-ben-ali: it would be great if you could test this with one of your data sets featuring a SCALE-RAT-FUNC compu method... |
kayoub5
approved these changes
Sep 19, 2024
|
@andlaus yes sure I'll do that. |
|
Ok, I merge this now. @nada-ben-ali: if you find any issues with your datasets don't hesitate to open an issue (or -- even better -- a pull request) |
|
@andlaus I've just tested the changes with a certain pdx file that contains SCALE-RAT-FUNC and I haven't observed any problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the compu methods specified by the ODX standard which have so far been MIA in
odxtools. These areCOMPUCODE,RAT-FUNCandSCALE-RAT-FUNC.Andreas Lauser <andreas.lauser@mercedes-benz.com>, on behalf of MBition GmbH.
Provider Information