implement sub-components #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sub-components are a mechanism to group physically or logically related diagnostic variables of an ECU. As far as I can see, sub-components are purely informative and optional. Also, they are (probably) only relevant for the (somewhat uncommon) communication mechanism based on diagnostic variables. Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Christian Hackenbeck <christian.hackenbeck@mbition.io>
Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Christian Hackenbeck <christian.hackenbeck@mbition.io>
andlaus
force-pushed
the
implement_subcomponents
branch
from
b70afb9 to
fa65cb7
Compare
kayoub5
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sub-components are a mechanism to group physically or logically related diagnostic variables of an ECU. As far as I can see, sub-components are purely informative and optional. Also, they are (probably) only relevant for the (somewhat uncommon) communication mechanism based on diagnostic variables.
Since I do not have any datasets which use this feature in earnest and I'm too lazy to write a comprehensive unit test, your mileage may vary a bit. (there should be no major screwups, though...)
Andreas Lauser <andreas.lauser@mercedes-benz.com>, on behalf of MBition GmbH.
Provider Information