Fix issue #375 and PR #373 #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…solved reference When resolving the table row in `TableKeyParameter`, whether or not the references of that object have been resolved is undefined. Since the table is a reference in table rows, so far an exception gets raised in `TableKeyParameter` depending on the phase of the moon. (i.e., whether `._resolve_odxlinks()` has been called at this point for the table row in question or not.) This has been discovered by @mafei1982. Thanks! Signed-off-by: Andreas Lauser <andreas.lauser@mercedes-benz.com> Signed-off-by: Gerrit Ecke <gerrit.ecke@mercedes-benz.com>
`EncodeState.emplace_bytes()` expects the bit position to be zero or it raises an exception. We should thus reset the bit position of `encode_state` before calling `.emplace_bytes()` instead of after it. this issue has been reported by @cmydd. Thanks! Signed-off-by: Andreas Lauser <andreas.lauser@mercedes-benz.com> Signed-off-by: Gerrit Ecke <gerrit.ecke@mercedes-benz.com>
kayoub5
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes #375 and the non-snref related part of #373 .
Andreas Lauser <andreas.lauser@mercedes-benz.com>, on behalf of MBition GmbH.
Provider Information