Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centralized struct bit length calculation #72

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Centralized struct bit length calculation #72

merged 1 commit into from
Sep 1, 2022

Conversation

kayoub5
Copy link
Collaborator

@kayoub5 kayoub5 commented Aug 29, 2022

  • BasicStructure.bit_length do not take into consideration EndOfPduField
  • BasicStructure.convert_physical_to_internal recalculates bit_length without taking into consideration overlapped parameters and gaps

Centralize the two implementations into one that takes into consideration the special cases of both

@kayoub5
Copy link
Collaborator Author

kayoub5 commented Aug 30, 2022

@andlaus review?

@andlaus
Copy link
Collaborator

andlaus commented Sep 1, 2022

looks good, thanks for the catch. merging...

@andlaus andlaus merged commit 4a38e5d into mercedes-benz:main Sep 1, 2022
@kayoub5 kayoub5 deleted the feature/struct_bit_length_centralized branch September 1, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kayoub5 @andlaus