Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade SpringBoot to version 2.5 #609

Closed
Jeeppler opened this issue Apr 23, 2021 · 4 comments · Fixed by #687
Closed

Upgrade SpringBoot to version 2.5 #609

Jeeppler opened this issue Apr 23, 2021 · 4 comments · Fixed by #687
Assignees
@de-jcup
Labels
change management
Milestone
Server 0.26.0, PD...

Comments

@Jeeppler
Copy link
Member

The objective of SecHub is to stay up to date with SpringBoot releases.
@Jeeppler Jeeppler mentioned this issue Apr 23, 2021
Closed
@Jeeppler Jeeppler mentioned this issue May 3, 2021
Closed
@Jeeppler
Copy link
Member Author

Spring Boot 2.5 should be released on the: May 20 2021: https://spring.io/blog/2021/04/15/spring-boot-2-5-0-rc1-available-now

@Jeeppler
Copy link
Member Author

Jeeppler commented May 25, 2021 •
edited
Loading

Spring Boot 2.5 is now GA: https://spring.io/blog/2021/05/20/spring-boot-2-5-is-now-ga

@Jeeppler Jeeppler mentioned this issue May 25, 2021
Closed
@de-jcup
Copy link
Member

de-jcup commented Jul 1, 2021

Current version is now 2.5.2 see https://spring.io/projects/spring-boot

@de-jcup de-jcup self-assigned this Jul 1, 2021
@de-jcup
Copy link
Member

de-jcup commented Jul 1, 2021 •
edited
Loading

When switching to spring boot 2.5.2 we have following error message inside our gradle build:

Failed to apply plugin 'org.springframework.boot'.
Spring Boot plugin requires Gradle 6.8.x, 6.9.x, or 7.x. The current version is Gradle 6.7.1

So we will upgrade to gradle version 6.9 - The necessary steps to upgrade to 7.0 as mentioned in #495 does take more time and will not be done inside this issue.

The upgrade will be done as mentioned inside https://docs.gradle.org/6.9/release-notes.html#upgrade-instructions :

./gradlew wrapper --gradle-version=6.9

de-jcup added a commit that referenced this issue Jul 1, 2021
@de-jcup
Updated dependencies for Spring Boot 2.5.2 #609
1e49b94 
- upgraded spring to 2.52
- upgraded gradle wrapper and gradle version to 6.9
de-jcup added a commit that referenced this issue Jul 2, 2021
@de-jcup
Fix compile errors with spring boot 2.5 #609
3f35bfc 
- Former deprecated method ErrorController#getErrorPath was removed
  in Spring Boot 2.5.
  see spring-projects/spring-boot#19844
- setting now `server.error.path` in PDS and SecHub server and using
  the variable inside error controller implementations
de-jcup added a commit that referenced this issue Jul 2, 2021
@de-jcup
Fixed failing wiremock tests #609
853ed24 
- multipart checks changed, because now always with boundary
@de-jcup de-jcup mentioned this issue Jul 2, 2021
Merged
de-jcup added a commit that referenced this issue Jul 6, 2021
@de-jcup
Update to Spring Boot 2.5.2 #609
c4bb6fd 
- upgraded used Spring Boot version to 2.5.2
- upgraded gradle wrapper and gradle version to 6.9 (necessary for newer Spring Boot version)
- fixed compile errors with spring boot 2.5:
  - former deprecated method ErrorController#getErrorPath was removed in Spring Boot 2.5.
    see spring-projects/spring-boot#19844
  - setting now `server.error.path` in PDS and SecHub server and using the variable inside error controller
    implementations
- fixed failing wiremock tests by changing multipart checks (because now always with boundary)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@de-jcup de-jcup

Labels
change management
Projects
None yet
Milestone
Server 0.26.0, PDS 0.23.0
Development

Successfully merging a pull request may close this issue.

Feature 609 upgrade to spring boot 2.5 mercedes-benz/sechub
2 participants
@Jeeppler @de-jcup