Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: improve ide usage clarity #102

Merged
merged 6 commits into from
Jan 9, 2020
Merged

Refactoring: improve ide usage clarity #102

merged 6 commits into from
Jan 9, 2020

Conversation

dougg0k
Copy link
Contributor

@dougg0k dougg0k commented Jan 9, 2020

I wanted to improve the clarity on the ide feature.

@dougg0k
Copy link
Contributor Author

dougg0k commented Jan 9, 2020

We could also have graphiql as the default option, without having to set anything in the ide.

mcollina
mcollina requested changes Jan 9, 2020
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer not to bump the major. Would you mind aliasing the old property to the new one?

mcollina
mcollina reviewed Jan 9, 2020
View reviewed changes
index.d.ts Show resolved Hide resolved
mcollina
mcollina approved these changes Jan 9, 2020
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit cad235a into mercurius-js:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dougg0k @mcollina