make getrawtransactions not do slow search by default. #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonypizzicato
requested changes
Apr 5, 2018
src/rpc/rawtransaction.cpp
Outdated
| @@ -175,7 +175,7 @@ UniValue getrawtransaction(const JSONRPCRequest& request) | |||
| { | |||
| if (request.fHelp || request.params.size() < 1 || request.params.size() > 2) | |||
There was a problem hiding this comment.
you need to update this one
tonypizzicato
approved these changes
Apr 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't do the slow utxo check in getrawtransaction if a transaction is not found by default. Added a parameter to enable the slow check if the user really, really wants to (but they won't want to).
Also updated the locks to cs_main to be held for a shorter amount of time in GetTransaction and GetReferral