New RPC call, getaddressrank and getaddressleaderboard #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mempko
changed the title
robertzk
reviewed
Jun 9, 2018
src/rpc/misc.cpp
Outdated
| UniValue o(UniValue::VOBJ); | ||
|
|
||
| //percentile to two digits | ||
| double percentile = |
There was a problem hiding this comment.
Another approach might be to sprintf("%.2f", (static_cast<double>(r.second) / static_cast<double>(total)) * 100)
There was a problem hiding this comment.
Thanks for the code review suggestions!
src/rpc/misc.cpp
Outdated
| } | ||
|
|
||
| CAmount lottery_anv = pog::GetCachedTotalANV(); | ||
| if(lottery_anv == 0) { |
src/rpc/misc.cpp
Outdated
| ); | ||
|
|
||
| CAmount lottery_anv = pog::GetCachedTotalANV(); | ||
| if(lottery_anv == 0) { |
src/rpc/misc.cpp
Outdated
| return rankarr; | ||
| } | ||
|
|
||
| UniValue getaddressrank(const JSONRPCRequest& request) |
There was a problem hiding this comment.
Some DRY + duplication between this and getaddressleaderboard. I don't have a concrete suggestion for how to address it but something to consider.
src/validation.cpp
Outdated
| referral::AddressANVs entrants; | ||
|
|
||
| // unlikely that the candidates grew over 50% since last time. | ||
| auto reserve_size = max_embassador_lottery * 1.5; |
There was a problem hiding this comment.
Nitpick: it's s/embassador/ambassador (unless this is on purpose and I'm not familiar with the jargon).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to promote more transparency into the ambassador reward lottery, this PR introduces an RPC call called "getaddressrank", which provides information about an addresses rank in the community and enough information to compute a probability of winning an ambassador reward.