Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: skip launching puppeteer when not needed #696

Conversation

aloisklink
Copy link
Member

📑 Summary

Skip launching puppeteer until it's actually needed.

Running mermaid-cli on a markdown file without any mermaid code blocks shouldn't launch puppeteer, if it's unnecessary.

Resolves #694

📏 Design Decisions

N/A

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted master branch

Skip launching puppeteer until it's actually needed.

Running mermaid-cli on a markdown file without any mermaid code blocks
shouldn't launch puppeteer, if it's unnecessary.

Fix: mermaid-js#694
@MindaugasLaganeckas MindaugasLaganeckas merged commit 22761ea into mermaid-js:master Jun 4, 2024
8 checks passed
@MindaugasLaganeckas
Copy link
Member

MindaugasLaganeckas commented Jun 4, 2024

Thank you!

@aloisklink aloisklink deleted the perf-694/skip-loading-puppeteer-when-not-needed branch June 4, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve performance of markdown file processing
2 participants