-
-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs button - fix paths to respective page on Mermaid JS docs site #1329
Conversation
✅ Deploy Preview for mermaidjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
1 failed test on run #1187 ↗︎
Details:
cypress/e2e/docMap.spec.ts • 1 failed test
Review all test suite changes for PR #1329 ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this approach every documentation change will lead to broken links within live editor. Not sure if we should not this logic inside documentation pages. Re-checked links, they seem to be working
We have to fix cypress tests as well |
We have the redirects logic in the documentation site to handle this issue. But, I noticed that the redirect works locally, but throws 404 when deployed. So we'll need to fix that in the docs site, as there will be other sites that link to the docs. |
Closed in favour of #1335 |
📑 Summary
This PR contains the following updates:
Resolves #
4989 from Mermaid JS repo
📏 Design Decisions
Describe the way your implementation works or what design decisions you made if applicable:
📋 Tasks
Make sure you
develop
branch