Skip to content

Commit

Permalink
Merge pull request #3535 from aloisklink/docs/replace-yarn-with-pnpm
Browse files Browse the repository at this point in the history
docs: replace `yarn` with `pnpm` in dev guide
  • Loading branch information
knsv authored Sep 30, 2022
2 parents 2f4b4ba + 794b714 commit f5dc4d9
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 9 deletions.
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ Here are a few things to know to get you started on the right path.
```bash
git clone git@github.com:mermaid-js/mermaid.git
cd mermaid
yarn
yarn test
pnpm install
pnpm test
```

## Committing code
Expand Down Expand Up @@ -103,7 +103,7 @@ This is important so that, if someone else does a change to the grammar that doe

This tests the rendering and visual appearance of the diagram. This ensures that the rendering of that feature in the e2e will be reviewed in the release process going forward. Less chance that it breaks!

To start working with the e2e tests, run `yarn dev` to start the dev server, after that start cypress by running `cypress open` in the mermaid folder. (Make sure you have path to cypress in order, the binary is located in node_modules/.bin).
To start working with the e2e tests, run `pnpm run dev` to start the dev server, after that start cypress by running `pnpm exec cypress open` in the mermaid folder.

The rendering tests are very straightforward to create. There is a function imgSnapshotTest. This function takes a diagram in text form, the mermaid options and renders that diagram in cypress.

Expand Down
5 changes: 2 additions & 3 deletions docs/development.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,8 @@ This tests the rendering and visual appearance of the diagrams. This ensures tha

To start working with the e2e tests:

1. Run `yarn dev` to start the dev server
2. Start **Cypress** by running `cypress open` in the **mermaid** folder.
(Make sure you have path to Cypress in order, the binary is located in `node_modules/.bin`).
1. Run `pnpm run dev` to start the dev server
2. Start **Cypress** by running `pnpm exec cypress open` in the **mermaid** folder.

The rendering tests are very straightforward to create. There is a function `imgSnapshotTest`, which takes a diagram in text form and the mermaid options, and it renders that diagram in Cypress.

Expand Down
5 changes: 2 additions & 3 deletions packages/mermaid/src/docs/development.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,8 @@ This tests the rendering and visual appearance of the diagrams. This ensures tha

To start working with the e2e tests:

1. Run `yarn dev` to start the dev server
2. Start **Cypress** by running `cypress open` in the **mermaid** folder.
(Make sure you have path to Cypress in order, the binary is located in `node_modules/.bin`).
1. Run `pnpm run dev` to start the dev server
2. Start **Cypress** by running `pnpm exec cypress open` in the **mermaid** folder.

The rendering tests are very straightforward to create. There is a function `imgSnapshotTest`, which takes a diagram in text form and the mermaid options, and it renders that diagram in Cypress.

Expand Down

0 comments on commit f5dc4d9

Please sign in to comment.