Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Border attribute does not work in a certain writing style #3263

Closed
yaeda opened this issue Jul 26, 2022 · 2 comments · Fixed by #3636
Closed

Border attribute does not work in a certain writing style #3263

yaeda opened this issue Jul 26, 2022 · 2 comments · Fixed by #3636
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect

Comments

@yaeda
Copy link

yaeda commented Jul 26, 2022

Describe the bug
Border attribute does not work in a certain writing style.

To Reproduce

Here are the samples. Please see borders:tb.

OK pattern

flowchart LR
  datastore[|borders:tb|Datastore] -->|input| process((System)) -->|output| entity[Customer]

shows

flowchart LR
  datastore[|borders:tb|Datastore] -->|input| process((System)) -->|output| entity[Customer]
Loading

NG pattern

flowchart LR
  datastore[|borders:tb|Datastore]
  process((System))
  entity[Customer]

  datastore -->|input| process -->|output| entity

shows

flowchart LR
  datastore[|borders:tb|Datastore]
  process((System))
  entity[Customer]

  datastore -->|input| process -->|output| entity
Loading

Expected behavior
The same rendering results are obtained with the above two styles.

Desktop (please complete the following information):

  • OS: macOS 12.4
  • Chrome
  • Version 103.0.5060.134
@yaeda yaeda added Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect labels Jul 26, 2022
@StevenIsaacs
Copy link

Another example:

flowchart LR
p((process))
ds[|borders:tb|ds] --> p
ds2[|borders:tb|ds2] --> p
p --> ds2

Renders as:

flowchart LR
  p((process))
  ds[|borders:tb|ds] --> p
  ds2[|borders:tb|ds2] --> p
  p --> ds2
Loading

Borders has no effect when ds2 is referenced.

@maiermic
Copy link
Contributor

I'm looking into this right now. In the example,

flowchart LR
  datastore[|borders:tb|Datastore]
  process((System))
  entity[Customer]

  datastore -->|input| process -->|output| entity

node.props.borders is not defined in src/dagre-wrapper/nodes.js. I still have to figure out why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants