Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rogue console.log #3339

Closed
Tracked by #3340
sidharthv96 opened this issue Aug 21, 2022 · 2 comments · Fixed by #3405
Closed
Tracked by #3340

Remove rogue console.log #3339

sidharthv96 opened this issue Aug 21, 2022 · 2 comments · Fixed by #3405
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect

Comments

@sidharthv96
Copy link
Member

Describe the bug
There are rogue console.logs which pollute the console of sites that embed mermaid.

To Reproduce
Steps to reproduce the behavior:

Expected behavior
No logs unless loglevel is set.

Screenshots
image
@sidharthv96 sidharthv96 added Type: Bug / Error Something isn't working or is incorrect Status: Triage Needs to be verified, categorized, etc labels Aug 21, 2022
@sidharthv96 sidharthv96 mentioned this issue Aug 31, 2022
Open
15 tasks
@knsv
Copy link
Collaborator

knsv commented Sep 2, 2022

Lets remove them all and create a cypress test for it!

@sidharthv96
Copy link
Member Author

Maybe eslint might be able to help.

@aloisklink aloisklink mentioned this issue Sep 3, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

style: forbid using console in mermaid src code
2 participants
@knsv @sidharthv96