Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pending improvements - Tracker #3340

Open
9 of 15 tasks
sidharthv96 opened this issue Aug 21, 2022 · 1 comment
Open
9 of 15 tasks

Pending improvements - Tracker #3340

sidharthv96 opened this issue Aug 21, 2022 · 1 comment
Assignees
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect

Comments

@sidharthv96
Copy link
Member

sidharthv96 commented Aug 21, 2022

Noting down possible improvements while working on #3336

@sidharthv96 sidharthv96 added Type: Bug / Error Something isn't working or is incorrect Status: Triage Needs to be verified, categorized, etc labels Aug 21, 2022
@sidharthv96 sidharthv96 self-assigned this Sep 13, 2022
@dwhelan
Copy link

dwhelan commented Sep 20, 2022

Hey @sidharthv96! I have a fix for #1871 where markers spilled over with multiple diagrams on the same html page. The fix was to create unique id's for each marker using the id in the svg element as a prefix. So, the id of pointEnd would now be something like mermaid-123456789-pointEnd.

I am looking for related issues because I suspect my fix could resolve other oddities with rendering markers. So I was wondering what the purpose of arrowMarkerAbsolute is. Is it possible that we might not need absolute markers if they were introduced to solve something that unique marker ids would address?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

No branches or pull requests

2 participants