Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mermaid.init is not using the config that's passed. #3406

Closed
Tracked by #4108
, #4115
...
sidharthv96 opened this issue Sep 4, 2022 · 0 comments · Fixed by #4108
Closed
Tracked by #4108
, #4115
...

mermaid.init is not using the config that's passed. #3406

sidharthv96 opened this issue Sep 4, 2022 · 0 comments · Fixed by #4108
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect

Comments

@sidharthv96
Copy link
Member

Describe the bug
init function doesn't use the passed config while rendering, so we have to call mermaid.initialize before mermaid.init, which is confusing as mermaid.init does accept config.

To Reproduce
Steps to reproduce the behavior:

  1. Try a demo that just uses mermaid.init with a forest theme.

Expected behavior
Forest theme is used
@sidharthv96 sidharthv96 added Type: Bug / Error Something isn't working or is incorrect Status: Triage Needs to be verified, categorized, etc labels Sep 4, 2022
@sidharthv96 sidharthv96 mentioned this issue Oct 23, 2022
Merged
3 tasks
This was referenced Feb 19, 2023
Closed
Merged
sidharthv96 added a commit that referenced this issue Feb 19, 2023
@sidharthv96
fix(#3406, #3394): Remove init & initThrowsErrors
4ea7294 
New run function added as replacement.
sidharthv96 added a commit that referenced this issue Feb 19, 2023
@sidharthv96
Merge branch 'release/10.0.0' into sidv/esbuildV10
f48e48d 
* release/10.0.0:
  fix(#3406, #3394): Remove init & initThrowsErrors
  chore: Rename lazy loaded diagram definitions
  Skip flowchart-elk failing test
sidharthv96 added a commit that referenced this issue Feb 19, 2023
@sidharthv96
Merge branch 'release/10.0.0' into sidv/splitDiagrams
638362b 
* release/10.0.0: (333 commits)
  10.0.0-rc.3
  Export more types
  no side effects
  10.0.0-rc.2
  skip failing elk test
  Cleanup
  Update docs
  fix(#3406, #3394): Remove init & initThrowsErrors
  chore: Rename lazy loaded diagram definitions
  Skip flowchart-elk failing test
  Fix docs
  fix Server
  Fix lint
  Remove Readme
  Fix E2E Tests
  Fix tests
  feat: Break render and parse types
  chore: Remove all non async render/parse/init
  Remove CJS builds from docs
  chore: Remove cjs from build
  ...
@sidharthv96 sidharthv96 linked a pull request Feb 19, 2023 that will close this issue
Release/10.0.0 #4108
Merged
10 tasks
@sidharthv96 sidharthv96 mentioned this issue Feb 20, 2023
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release/10.0.0 mermaid-js/mermaid
1 participant
@sidharthv96