Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1378 additional qualifiers bug with multiple arguments #1446

Merged
merged 8 commits into from
Jun 10, 2020
Merged

1378 additional qualifiers bug with multiple arguments #1446

merged 8 commits into from
Jun 10, 2020

Conversation

jgreywolf
Copy link
Contributor

📑 Summary

Updated/improved regex to ensure proper elements are being captured

Resolves #1378

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

@jgreywolf jgreywolf requested review from knsv and GDFaber June 6, 2020 00:14
knsv
knsv reviewed Jun 6, 2020
View reviewed changes
Copy link
Collaborator

@knsv knsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look fine as usual! The node addition we should discuss.

@jgreywolf jgreywolf force-pushed the 1378-AdditionalQualifiersBugWithMultipleArguments branch from 7c19dc2 to 9091d68 Compare June 9, 2020 01:43
@jgreywolf
Copy link
Contributor Author

Code changes look fine as usual! The node addition we should discuss.

Removed the node changes, not sure why that was added in.

@jgreywolf jgreywolf requested a review from knsv June 9, 2020 21:32
@jgreywolf jgreywolf linked an issue Jun 10, 2020 that may be closed by this pull request
Faulty parsing of methods in class diagrams #1455
Closed
@knsv knsv merged commit 2bb6922 into mermaid-js:develop Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knsv knsv knsv approved these changes

@GDFaber GDFaber Awaiting requested review from GDFaber

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Faulty parsing of methods in class diagrams Class Diagram method additional classifers error
2 participants
@jgreywolf @knsv