Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1473 default config #1477

Merged
merged 8 commits into from
Jun 16, 2020
Merged

1473 default config #1477

merged 8 commits into from
Jun 16, 2020

Conversation

knsv
Copy link
Collaborator

@knsv knsv commented Jun 15, 2020

📑 Summary

Restoring default config handling after addition of directives.

Resolves #1473

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

@knsv knsv merged commit e4b63a6 into develop Jun 16, 2020
@chrismoran-bkt
Copy link
Contributor

Apologies for this! I was actually working on a small refactor for the directives which successfully merges init with the config so it doesn't bomb/remove the original default config.

@knsv knsv deleted the 1473_default_config branch June 19, 2020 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default config is lost after directives update
2 participants