Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(flowchart): Allow default in the node ID #2513

Merged
merged 5 commits into from
Dec 11, 2021
Merged

feat(flowchart): Allow default in the node ID #2513

merged 5 commits into from
Dec 11, 2021

Conversation

Yash-Singh1
Copy link
Member

📑 Summary

Allow the default word in node IDs
Resolves #2388

📏 Design Decisions

Just permits DEFAULT to be counted as a idStringToken too.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

@Yash-Singh1 Yash-Singh1 mentioned this pull request Nov 25, 2021
Closed
@knsv
Copy link
Collaborator

knsv commented Nov 29, 2021

Good job @Yash-Singh1! Glad to have you aboard!

@knsv knsv merged commit 6a45701 into develop Dec 11, 2021
@knsv knsv deleted the default_as_id_string_token branch August 23, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node names with special characters that break syntax
2 participants
@Yash-Singh1 @knsv