-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Class diagram accessibility #2911
Class diagram accessibility #2911
Conversation
@@ -345,8 +345,34 @@ const setDirection = (dir) => { | |||
direction = dir; | |||
}; | |||
|
|||
let title = ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to add the default "Class chart" title text here in case a user doesn't pass in anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am on the fence, if the title starts getting shown that is not ideal... Unless it gets the user to add a better title. I have been back and forth on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think there should be some work to get titles to show up on every chart. Perhaps this is a carrot to making things more accessible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohhhh right - I forgot that this would be shown to all users 😬 Let's skip for now, but maybe we can revisit the option to have a title displayed for each chart. That would definitely help with accessibility!
We are all for better accessibility! Much appreciated! |
📑 Summary
This adds titles to class diagrams.
📏 Design Decisions
Following the already set pattern for adding accessibility to charts, setup in #2732
📋 Tasks
Make sure you
develop
branch