Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds title and description to flowchart #2913

Merged
merged 2 commits into from
Apr 12, 2022

Conversation

lindseywild
Copy link
Contributor

@lindseywild lindseywild commented Apr 7, 2022

📑 Summary

  • Adds a title and accDescription to flow charts to improve accessibility.
  • Minor typos and grammar updates

Resolves part of #2732

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

@lindseywild lindseywild force-pushed the feat/flowchart-accessibility branch from 76d1d1f to 89385bb Compare April 7, 2022 14:58
@gwincr11 gwincr11 mentioned this pull request Apr 7, 2022
9 tasks
Copy link
Collaborator

@ashishjain0512 ashishjain0512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey

Thank you for your contribution. This we think will be quite a helpful for flowchart users. Good Job.

However, keeping the security risk in mind, we would suggest adding sanitization to user input. See the link for your reference:

Once this is done, we will be happy to merge it.

@lindseywild lindseywild force-pushed the feat/flowchart-accessibility branch from 89385bb to e2ec7fd Compare April 7, 2022 18:58
@lindseywild
Copy link
Contributor Author

@ashishjain0512 Great callout, thank you! I added the sanitization to the title and description, also cleaned up the function a bit.

@knsv
Copy link
Collaborator

knsv commented Apr 12, 2022

Super! Thanks for the update!

@knsv knsv merged commit 4f833db into mermaid-js:develop Apr 12, 2022
@lindseywild lindseywild deleted the feat/flowchart-accessibility branch April 12, 2022 10:29
@knsv knsv mentioned this pull request May 6, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants