Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add accessibility fields to requirements diagram #2915

Merged
merged 2 commits into from
Apr 12, 2022
Merged

feat: Add accessibility fields to requirements diagram #2915

merged 2 commits into from
Apr 12, 2022

Conversation

gwincr11
Copy link
Contributor

@gwincr11 gwincr11 commented Apr 7, 2022

📑 Summary

This adds titles to requirements diagrams.

📏 Design Decisions

Following the already set pattern for adding accessibility to charts, setup in #2732

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

@gwincr11 gwincr11 mentioned this pull request Apr 7, 2022
9 tasks
Co-authored-by: Lindsey Wild <35239154+lindseywild@users.noreply.github.com>
Copy link
Collaborator

@knsv knsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

I appreciate the extra effort you put in to also add the tests!

@knsv knsv merged commit 7d2e77a into mermaid-js:develop Apr 12, 2022
@knsv knsv mentioned this pull request May 6, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants