Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add accessible description and title to user journey #2919

Merged
merged 5 commits into from
Apr 12, 2022
Merged

feat: add accessible description and title to user journey #2919

merged 5 commits into from
Apr 12, 2022

Conversation

khiga8
Copy link
Contributor

@khiga8 khiga8 commented Apr 8, 2022 •
edited
Loading

📑 Summary

Resolves part of #2732

This adds an accessible title and description field to a user journey diagram to improve accessibility.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

knsv
knsv approved these changes Apr 12, 2022
View reviewed changes
Copy link
Collaborator

@knsv knsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Thanks for helping out, accessibility is important!

@knsv knsv merged commit 3c725b9 into mermaid-js:develop Apr 12, 2022
@gwincr11 gwincr11 mentioned this pull request Apr 12, 2022
Closed
9 tasks
@knsv knsv mentioned this pull request May 6, 2022
Merged
3 tasks
@khiga8 khiga8 deleted the kh-user-journey branch August 3, 2022 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knsv knsv knsv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khiga8 @knsv