Add generic and array symbols to erDiagram
#3335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knsv
reviewed
Aug 23, 2022
knsv
reviewed
Aug 23, 2022
|
|
||
| if (text.indexOf('~') != -1) { | ||
| cleanedText = cleanedText.replace('~', '<'); | ||
| cleanedText = cleanedText.replace('~', '>'); |
There was a problem hiding this comment.
Could this be used to insert tags? Scared of < and > nowdays...
There was a problem hiding this comment.
It shouldn't be the case because it gets inserted as a text. I've tried to insert some other styles without luck. The text just gets inserted. But thanks for pointing this out 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
[]) and generic (~T~) support toerDiagramResolves part of #3171
📏 Design Decisions
The way the implementation works is that matches an
ATTRIBUTE_WORDin a<block>before the normal match with the following regex<block>(.*?)[~](.*?)*[~]. This match gets directly parsed and evaluated at theerRenderer. In addition, I've added[]symbols to the normal parsing regex.📋 Tasks
Make sure you
developbranch